From 6912680ed4dda31958883b3f47f85e5327b91583 Mon Sep 17 00:00:00 2001 From: scott Date: Thu, 16 Apr 2026 11:28:07 -0400 Subject: [PATCH] =?UTF-8?q?Fix=20fabric=20firmware=20version=20path=20?= =?UTF-8?q?=E2=80=94=20add=20VikingEnterpriseSolutions=20key?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Redfish response nests the version under Oem.VikingEnterpriseSolutions.Version.ActiveFirmwareVersion, not Oem.Version.ActiveFirmwareVersion. Fixed in both redfish.py (_get_fabric_fw_version, used by network check and firmware workflow) and workflow_check.py (serial inline parsing). Co-Authored-By: Claude Sonnet 4.6 --- modules/redfish.py | 1 + modules/workflow_check.py | 1 + 2 files changed, 2 insertions(+) diff --git a/modules/redfish.py b/modules/redfish.py index dd84115..48cbf23 100644 --- a/modules/redfish.py +++ b/modules/redfish.py @@ -208,6 +208,7 @@ def _get_fabric_fw_version(password: str, host: str, iom: str) -> str: ) if ok_flag and isinstance(data, dict): version = (data.get("Oem", {}) + .get("VikingEnterpriseSolutions", {}) .get("Version", {}) .get("ActiveFirmwareVersion")) return version or "Unknown" diff --git a/modules/workflow_check.py b/modules/workflow_check.py index ccb95d3..b407f6a 100644 --- a/modules/workflow_check.py +++ b/modules/workflow_check.py @@ -151,6 +151,7 @@ def _check_via_serial(): ) fab_ver = ( (fab_data.get("Oem", {}) + .get("VikingEnterpriseSolutions", {}) .get("Version", {}) .get("ActiveFirmwareVersion", "Unknown")) if (fab_ok and isinstance(fab_data, dict))