Move etcd, logger, crypto into their own packages (#8366)

- Deprecates _MINIO_PROFILER, `mc admin profile` does the job
- Move ENVs to common location in cmd/config/

cmd/consolelogger.go

@@ -19,6 +19,7 @@ package cmd
 import (
 	ring "container/ring"
 	"context"
+	"sync"
 
 	"github.com/minio/minio/cmd/logger"
 	"github.com/minio/minio/cmd/logger/message/log"
@@ -36,6 +37,8 @@ type HTTPConsoleLoggerSys struct {
 	pubsub   *pubsub.PubSub
 	console  *console.Target
 	nodeName string
+	// To protect ring buffer.
+	logBufLk sync.RWMutex
 	logBuf   *ring.Ring
 }
 
@@ -52,7 +55,7 @@ func NewConsoleLogger(ctx context.Context, endpoints EndpointList) *HTTPConsoleL
 	}
 	ps := pubsub.New()
 	return &HTTPConsoleLoggerSys{
-		ps, nil, nodeName, ring.New(defaultLogBufferCount),
+		ps, nil, nodeName, sync.RWMutex{}, ring.New(defaultLogBufferCount),
 	}
 }
 
@@ -78,13 +81,14 @@ func (sys *HTTPConsoleLoggerSys) Subscribe(subCh chan interface{}, doneCh chan s
 	}
 
 	lastN = make([]madmin.LogInfo, last)
-	r := sys.logBuf
-	r.Do(func(p interface{}) {
+	sys.logBufLk.RLock()
+	sys.logBuf.Do(func(p interface{}) {
 		if p != nil && (p.(madmin.LogInfo)).SendLog(node) {
 			lastN[cnt%last] = p.(madmin.LogInfo)
 			cnt++
 		}
 	})
+	sys.logBufLk.RUnlock()
 	// send last n console log messages in order filtered by node
 	if cnt > 0 {
 		for i := 0; i < last; i++ {
@@ -102,8 +106,11 @@ func (sys *HTTPConsoleLoggerSys) Subscribe(subCh chan interface{}, doneCh chan s
 	sys.pubsub.Subscribe(subCh, doneCh, filter)
 }
 
-// Console returns a  console target
+// Console returns a console target
 func (sys *HTTPConsoleLoggerSys) Console() *HTTPConsoleLoggerSys {
+	if sys == nil {
+		return sys
+	}
 	if sys.console == nil {
 		sys.console = console.New()
 	}
@@ -122,9 +129,11 @@ func (sys *HTTPConsoleLoggerSys) Send(e interface{}) error {
 	}
 
 	sys.pubsub.Publish(lg)
+	sys.logBufLk.Lock()
 	// add log to ring buffer
 	sys.logBuf.Value = lg
 	sys.logBuf = sys.logBuf.Next()
+	sys.logBufLk.Unlock()
 
 	if globalServerConfig.Logger.Console.Enabled {
 		return sys.console.Send(e)