scott/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2026-02-04 18:00:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: return error on conditional write for non existing object (#21550)

Browse Source
This commit is contained in:
M Alvee
2025-09-06 10:34:38 -07:00
committed by GitHub
parent 9fdbf6fe83
commit 558fc1c09c
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cmd/erasure-object.go
View File

@@ -1277,6 +1277,11 @@ func (er erasureObjects) putObject(ctx context.Context, bucket string, object st
if err != nil && !isErrVersionNotFound(err) && !isErrObjectNotFound(err) && !isErrReadQuorum(err) { if err != nil && !isErrVersionNotFound(err) && !isErrObjectNotFound(err) && !isErrReadQuorum(err) {
return objInfo, err return objInfo, err
} }
// if object doesn't exist and not a replication request return error for conditional requests
if err != nil && !opts.ReplicationRequest {
return objInfo, err
}
} }
// Validate input data size and it can never be less than -1. // Validate input data size and it can never be less than -1.

8
cmd/object-api-options.go
View File

@@ -414,12 +414,16 @@ func putOptsFromHeaders(ctx context.Context, hdr http.Header, metadata map[strin
if err != nil { if err != nil {
return ObjectOptions{}, err return ObjectOptions{}, err
} }
return ObjectOptions{ op := ObjectOptions{
ServerSideEncryption: sseKms, ServerSideEncryption: sseKms,
UserDefined: metadata, UserDefined: metadata,
MTime: mtime, MTime: mtime,
PreserveETag: etag, PreserveETag: etag,
}, nil }
if _, ok := hdr[xhttp.MinIOSourceReplicationRequest]; ok {
op.ReplicationRequest = true
}
return op, nil
} }
// default case of passing encryption headers and UserDefined metadata to backend // default case of passing encryption headers and UserDefined metadata to backend
opts, err = getDefaultOpts(hdr, false, metadata) opts, err = getDefaultOpts(hdr, false, metadata)